Re: [Qemu-devel] [PATCH 1/3] block/ssh: Pull ssh_grow_file() from ssh_create()

[Eric Blake]

On 02/14/2018 02:49 PM, Max Reitz wrote:
> If we ever want to offer even rudimentary truncation functionality for
> ssh, we should put the respective code into a reusable function.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
>   block/ssh.c | 30 ++++++++++++++++++++++--------
>   1 file changed, 22 insertions(+), 8 deletions(-)

> +++ b/block/ssh.c
> @@ -803,6 +803,26 @@ static int ssh_file_open(BlockDriverState *bs, QDict 
> *options, int bdrv_flags,
>       return ret;
>   }
>   
> +static int ssh_grow_file(BDRVSSHState *s, int64_t offset, Error **errp)
> +{
> +    ssize_t ret;
> +    char c[1] = { '\0' };

Could spell this 'char c[1] = "";', but you just did code motion.

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org