[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 4/6] raspi: Specify the valid CPUs
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH v5 4/6] raspi: Specify the valid CPUs |
Date: |
Thu, 15 Feb 2018 10:04:08 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
Hi Peter,
On 02/15/2018 08:29 AM, Peter Maydell wrote:
> On 2 February 2018 at 00:42, Alistair Francis
> <address@hidden> wrote:
>> List all possible valid CPU options.
>>
>> Signed-off-by: Alistair Francis <address@hidden>
>> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
>> ---
>>
>> V5:
>> - Use cpu_model names
>> V4:
>> - Remove spaces
>> V3:
>> - Add static property
>> V2:
>> - Fix the indentation
>>
>> hw/arm/raspi.c | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/hw/arm/raspi.c b/hw/arm/raspi.c
>> index cd5fa8c3dc..745a880726 100644
>> --- a/hw/arm/raspi.c
>> +++ b/hw/arm/raspi.c
>> @@ -158,6 +158,11 @@ static void raspi2_init(MachineState *machine)
>> setup_boot(machine, 2, machine->ram_size - vcram_size);
>> }
>>
>> +static const char *raspi2_valid_cpus[] = {
>> + "cortex-a7",
>> + NULL
>> +};
>
> Is this definitely right? Looking at the code, the raspi2 board
> creates a TYPE_BCM2836, and that creates cortex-a15 CPUs...
The BCM2836 use a cortex-a7 but this cpu was not available at the time
of this commit (bad5623690b) and was added later in dcf578ed8ce "The A7
is very similar to the A15."
I can prepare a patch for it to apply before this series.
>
> thanks
> -- PMM
>
- [Qemu-devel] [PATCH v5 0/6] Add a valid_cpu_types property, Alistair Francis, 2018/02/01
- [Qemu-devel] [PATCH v5 1/6] machine: Convert the valid cpu types to use cpu_model, Alistair Francis, 2018/02/01
- Re: [Qemu-devel] [PATCH v5 1/6] machine: Convert the valid cpu types to use cpu_model, Eduardo Habkost, 2018/02/02
- Re: [Qemu-devel] [PATCH v5 1/6] machine: Convert the valid cpu types to use cpu_model, Igor Mammedov, 2018/02/05
- Re: [Qemu-devel] [PATCH v5 1/6] machine: Convert the valid cpu types to use cpu_model, Eduardo Habkost, 2018/02/05
- Re: [Qemu-devel] [PATCH v5 1/6] machine: Convert the valid cpu types to use cpu_model, Igor Mammedov, 2018/02/05
- Re: [Qemu-devel] [PATCH v5 1/6] machine: Convert the valid cpu types to use cpu_model, Eduardo Habkost, 2018/02/05
- Re: [Qemu-devel] [PATCH v5 1/6] machine: Convert the valid cpu types to use cpu_model, Igor Mammedov, 2018/02/06
[Qemu-devel] [PATCH v5 4/6] raspi: Specify the valid CPUs, Alistair Francis, 2018/02/01
[Qemu-devel] [PATCH v5 3/6] bcm2836: Use the Cortex-A7 instead of Cortex-A15, Alistair Francis, 2018/02/01
[Qemu-devel] [PATCH v5 2/6] netduino2: Specify the valid CPUs, Alistair Francis, 2018/02/01
[Qemu-devel] [PATCH v5 6/6] xilinx_zynq: Specify the valid CPUs, Alistair Francis, 2018/02/01
[Qemu-devel] [PATCH v5 5/6] xlnx-zcu102: Specify the valid CPUs, Alistair Francis, 2018/02/01