qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [qemu-s390x] [PATCH v2] s390x/tcg: add various alignmen


From: Eric Blake
Subject: Re: [Qemu-devel] [qemu-s390x] [PATCH v2] s390x/tcg: add various alignment check
Date: Thu, 15 Feb 2018 08:13:27 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

On 02/15/2018 03:49 AM, Cornelia Huck wrote:
On Thu, 15 Feb 2018 10:47:45 +0100
David Hildenbrand <address@hidden> wrote:

On 14.02.2018 20:04, Richard Henderson wrote:
On 02/14/2018 09:31 AM, David Hildenbrand wrote:
Let's add proper alignment checks for a handful of instructions that
require a SPECIFICATION exception in case alignment is violated.

Introduce new wout/in functions. Declare them as "static inline" to avoid
warnings about not being used for CONFIG_USER_ONLY (as we are right
now only using them for privileged instructions).

Annoyingly, clang will still warn for this.

Hm, so the only solution is to add nasty idfefs then :(

Yup, very annoying indeed, but probably the only way to shut clang up...

Does marking the function __attribute__((unused)) shut up clang?

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



reply via email to

[Prev in Thread] Current Thread [Next in Thread]