Re: [Qemu-devel] [PATCH] vnc: remove bogus object_unref on client socket

[Eric Blake]

On 02/15/2018 04:26 AM, Daniel P. Berrangé wrote:
> vnc_listen_io() does not own the reference on the 'cioc' parameter is it
> passed, so should not be unref'ing it.
>
> Reported-by: Bandan Das <address@hidden>
> Signed-off-by: Daniel P. Berrangé <address@hidden>
> ---
>   ui/vnc.c | 1 -
>   1 file changed, 1 deletion(-)

Reviewed-by: Eric Blake <address@hidden>

> diff --git a/ui/vnc.c b/ui/vnc.c
> index c715bae1cf..b97769aa9e 100644
> --- a/ui/vnc.c
> +++ b/ui/vnc.c
> @@ -3152,7 +3152,6 @@ static void vnc_listen_io(QIONetListener *listener,
>                            isWebsock ? "vnc-ws-server" : "vnc-server");
>       qio_channel_set_delay(QIO_CHANNEL(cioc), false);
>       vnc_connect(vd, cioc, false, isWebsock);
> -    object_unref(OBJECT(cioc));
>   }
>   
>   static const DisplayChangeListenerOps dcl_ops = {

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org