Re: [Qemu-devel] [PATCH 28/30] ivshmem: use the BYTE-based definitions

[Philippe Mathieu-Daudé]

On 02/15/2018 01:28 AM, Philippe Mathieu-Daudé wrote:
> It ease code review, unit is explicit.

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>

> ---
>  hw/misc/ivshmem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
> index 16f03701b7..9b3ad96471 100644
> --- a/hw/misc/ivshmem.c
> +++ b/hw/misc/ivshmem.c
> @@ -1302,7 +1302,7 @@ static void ivshmem_realize(PCIDevice *dev, Error 
> **errp)
>      }
>  
>      if (s->sizearg == NULL) {
> -        s->legacy_size = 4 << 20; /* 4 MB default */
> +        s->legacy_size = 4 * M_BYTE; /* 4 MB default */
>      } else {
>          int ret;
>          uint64_t size;
>