[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 1/6] build-sys: fix -fsanitize=address check
From: |
Marc-André Lureau |
Subject: |
[Qemu-devel] [PATCH 1/6] build-sys: fix -fsanitize=address check |
Date: |
Thu, 15 Feb 2018 22:25:47 +0100 |
Since 218bb57dd79d6843e0592c30a82ea8c1fddc74a5, the -fsanitize=address
check fails with:
config-temp/qemu-conf.c:3:20: error: integer overflow in expression
[-Werror=overflow]
return INT32_MIN / -1;
Interestingly, UBSAN check doesn't produce a compile time warning.
Use a test that doesn't have compile time warnings, and make it
specific to UBSAN check.
Signed-off-by: Marc-André Lureau <address@hidden>
---
configure | 22 ++++++++++++----------
1 file changed, 12 insertions(+), 10 deletions(-)
diff --git a/configure b/configure
index 913e14839d..cc610823e1 100755
--- a/configure
+++ b/configure
@@ -5306,25 +5306,27 @@ fi
##########################################
# checks for sanitizers
-# we could use a simple skeleton for flags checks, but this also
-# detect the static linking issue of ubsan, see also:
-# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84285
-cat > $TMPC << EOF
-#include <stdint.h>
-int main(void) {
- return INT32_MIN / -1;
-}
-EOF
-
have_asan=no
have_ubsan=no
have_asan_iface_h=no
have_asan_iface_fiber=no
if test "$sanitizers" = "yes" ; then
+ write_c_skeleton
if compile_prog "$CPU_CFLAGS -Werror -fsanitize=address" ""; then
have_asan=yes
fi
+
+ # we could use a simple skeleton for flags checks, but this also
+ # detect the static linking issue of ubsan, see also:
+ # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84285
+ cat > $TMPC << EOF
+#include <stdlib.h>
+int main(void) {
+ void *tmp = malloc(10);
+ return *(int *)(tmp + 2);
+}
+EOF
if compile_prog "$CPU_CFLAGS -Werror -fsanitize=undefined" ""; then
have_ubsan=yes
fi
--
2.16.1.73.g5832b7e9f2
- [Qemu-devel] [PATCH 0/6] vhost-user-test and leak fixes, Marc-André Lureau, 2018/02/15
- [Qemu-devel] [PATCH 2/6] lockable: workaround GCC link issue with ASAN, Marc-André Lureau, 2018/02/15
- [Qemu-devel] [PATCH 6/6] sdhci-test: fix leaks, Marc-André Lureau, 2018/02/15
- [Qemu-devel] [PATCH 5/6] ahci-test: fix opts leak of skip tests, Marc-André Lureau, 2018/02/15
- [Qemu-devel] [PATCH 4/6] vhost-user-test: do not hang if chardev creation failed, Marc-André Lureau, 2018/02/15
- [Qemu-devel] [PATCH 3/6] vhost-user-test: add back memfd check, Marc-André Lureau, 2018/02/15
- [Qemu-devel] [PATCH 1/6] build-sys: fix -fsanitize=address check,
Marc-André Lureau <=
- Re: [Qemu-devel] [PATCH 0/6] vhost-user-test and leak fixes, Paolo Bonzini, 2018/02/23