Re: [Qemu-devel] [PATCH v5 3/6] bcm2836: Use the Cortex-A7 instead of Cortex-A15

[Alistair Francis]

On Thu, Feb 15, 2018 at 5:23 AM, Philippe Mathieu-Daudé <address@hidden> wrote:
> Hi Peter,
>
> On 02/01/2018 09:42 PM, Alistair Francis wrote:
>> The BCM2836 uses a Cortex-A7 not a Cortex-A15. Update the device to use
>> the correct CPU.
>> https://www.raspberrypi.org/documentation/hardware/raspberrypi/bcm2836/QA7_rev3.4.pdf
>
> Can you add these lines with reference to the commits?
>
>   When the BCM2836 was introduced (bad5623690b) the Cortex-A7 was not
>   available, so the very similar Cortex-A15 was used.
>
>   Since dcf578ed8ce we can model the correct core.
>
> Thanks!

Added!

I'm not sure when I'll send the next version out though.

Alistair

>
> Phil.
>
>> Signed-off-by: Alistair Francis <address@hidden>
>> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
>> Reviewed-by: Igor Mammedov <address@hidden>
>> ---
>> V3:
>>  - Use ARM_CPU_TYPE_NAME() macro
>> V2:
>>  - Fix the BCM2836 CPU
>>
>>  hw/arm/bcm2836.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/arm/bcm2836.c b/hw/arm/bcm2836.c
>> index 8c43291112..c477772484 100644
>> --- a/hw/arm/bcm2836.c
>> +++ b/hw/arm/bcm2836.c
>> @@ -30,7 +30,7 @@ static void bcm2836_init(Object *obj)
>>
>>      for (n = 0; n < BCM2836_NCPUS; n++) {
>>          object_initialize(&s->cpus[n], sizeof(s->cpus[n]),
>> -                          "cortex-a15-" TYPE_ARM_CPU);
>> +                          ARM_CPU_TYPE_NAME("cortex-a7"));
>>          object_property_add_child(obj, "cpu[*]", OBJECT(&s->cpus[n]),
>>                                    &error_abort);
>>      }
>>