[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 10/20] sdcard: handle the Security Specificat
From: |
Alistair Francis |
Subject: |
Re: [Qemu-devel] [PATCH v4 10/20] sdcard: handle the Security Specification commands |
Date: |
Thu, 15 Feb 2018 14:54:24 -0800 |
On Thu, Feb 15, 2018 at 2:13 PM, Philippe Mathieu-Daudé <address@hidden> wrote:
> returning sd_illegal, since they are not implemented.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/sd/sd.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/hw/sd/sd.c b/hw/sd/sd.c
> index 30acd04ad7..0457f5214b 100644
> --- a/hw/sd/sd.c
> +++ b/hw/sd/sd.c
> @@ -1551,6 +1551,17 @@ static sd_rsp_type_t sd_app_command(SDState *sd,
> }
> break;
>
> + case 18: /* Reserved for SD security applications */
> + case 25:
> + case 26:
> + case 38:
> + case 43 ... 49:
> + /* Refer to the "SD Specifications Part3 Security Specification" for
> + * information about the SD Security Features */
The */ should be on a new line.
Otherwise:
Reviewed-by: Alistair Francis <address@hidden>
Alistair
> + qemu_log_mask(LOG_UNIMP, "SD: CMD%i Security not implemented\n",
> + req.cmd);
> + return sd_illegal;
> +
> default:
> /* Fall back to standard commands. */
> return sd_normal_command(sd, req);
> --
> 2.16.1
>
>
- [Qemu-devel] [PATCH v4 01/20] sdcard: Don't always set the high capacity bit, (continued)
- [Qemu-devel] [PATCH v4 01/20] sdcard: Don't always set the high capacity bit, Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [PATCH v4 02/20] sdcard: update the CSD CRC register regardless the CSD structure version, Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [PATCH v4 03/20] sdcard: fix the 'maximum data transfer rate' to 25MHz, Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [PATCH v4 04/20] sdcard: clean the SCR register and add few comments, Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [PATCH v4 05/20] sdcard: remove commands from unsupported old MMC specification, Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [PATCH v4 06/20] sdcard: simplify using the ldst API, Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [PATCH v4 07/20] sdcard: use the correct masked OCR in the R3 reply, Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [PATCH v4 08/20] sdcard: use the registerfields API for the CARD_STATUS register masks, Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [PATCH v4 09/20] sdcard: handle CMD54 (SDIO), Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [PATCH v4 10/20] sdcard: handle the Security Specification commands, Philippe Mathieu-Daudé, 2018/02/15
- Re: [Qemu-devel] [PATCH v4 10/20] sdcard: handle the Security Specification commands,
Alistair Francis <=
- [Qemu-devel] [PATCH v4 11/20] sdcard: use a more descriptive label 'unimplemented_spi_cmd', Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [PATCH v4 12/20] sdcard: handles more commands in SPI mode, Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [PATCH v4 13/20] sdcard: check the card is in correct state for APP CMD (CMD55), Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [PATCH v4 14/20] sdcard: warn if host uses an incorrect address for APP CMD (CMD55), Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [PATCH v4 15/20] sdcard: simplify SEND_IF_COND (CMD8), Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [PATCH v4 16/20] sdcard: simplify SD_SEND_OP_COND (ACMD41), Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [PATCH v4 17/20] sdcard: add SD SEND_TUNING_BLOCK (CMD19), Philippe Mathieu-Daudé, 2018/02/15