[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] tests/boot-serial-test: Fix problem with timeou
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] tests/boot-serial-test: Fix problem with timeout due to dropped characters |
Date: |
Fri, 16 Feb 2018 11:19:17 +0000 |
On 16 February 2018 at 10:25, Thomas Huth <address@hidden> wrote:
> PS: I think the OpenBSD compiler is wrong here, nbr should get
> initialized at least once before the g_assert(nbr >= 0) check ...
Yes, I agree, but it does require some intelligence on the
part of the compiler to figure out that the ccnt++ < 512
condition can't trigger first time round the loop. (It's
a gcc 4.9.3, so presumably newer gcc are indeed smarter.)
Applied to master.
thanks
-- PMM