[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] monitor.c: Fix infinite loop in monitor's auto-
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH] monitor.c: Fix infinite loop in monitor's auto-complete |
Date: |
Fri, 16 Feb 2018 16:20:19 +0000 |
User-agent: |
Mutt/1.9.2 (2017-12-15) |
* Dr. David Alan Gilbert (git) (address@hidden) wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
>
> Reported-by: Dimitris Karagkasidis <address@hidden>
> Fixes: 48fe86f6400574165979e0db6f5937ad487b6888
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Queued.
> ---
> monitor.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/monitor.c b/monitor.c
> index 0c0faec0a4..bec484440f 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -3696,7 +3696,7 @@ static void monitor_find_completion_by_table(Monitor
> *mon,
> {
> const char *cmdname;
> int i;
> - const char *ptype, *str, *name;
> + const char *ptype, *old_ptype, *str, *name;
> const mon_cmd_t *cmd;
> BlockBackend *blk = NULL;
>
> @@ -3741,7 +3741,9 @@ static void monitor_find_completion_by_table(Monitor
> *mon,
> }
> }
> str = args[nb_args - 1];
> - while (*ptype == '-' && ptype[1] != '\0') {
> + old_ptype = NULL;
> + while (*ptype == '-' && old_ptype != ptype) {
> + old_ptype = ptype;
> ptype = next_arg_type(ptype);
> }
> switch(*ptype) {
> --
> 2.14.3
>
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK