[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 6/7] hw/sd: make sd_data_ready() static
From: |
Alistair Francis |
Subject: |
Re: [Qemu-devel] [PATCH v3 6/7] hw/sd: make sd_data_ready() static |
Date: |
Fri, 16 Feb 2018 13:02:17 -0800 |
On Thu, Feb 15, 2018 at 6:29 PM, Philippe Mathieu-Daudé <address@hidden> wrote:
> It belongs to the legacy API (the last user has been converted).
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Alistair Francis <address@hidden>
Alistair
> ---
> include/hw/sd/sd.h | 1 -
> hw/sd/sd.c | 2 +-
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/hw/sd/sd.h b/include/hw/sd/sd.h
> index bf1eb0713c..4491db98de 100644
> --- a/include/hw/sd/sd.h
> +++ b/include/hw/sd/sd.h
> @@ -138,7 +138,6 @@ int sd_do_command(SDState *sd, SDRequest *req,
> void sd_write_data(SDState *sd, uint8_t value);
> uint8_t sd_read_data(SDState *sd);
> void sd_set_cb(SDState *sd, qemu_irq readonly, qemu_irq insert);
> -bool sd_data_ready(SDState *sd);
> /* sd_enable should not be used -- it is only used on the nseries boards,
> * where it is part of a broken implementation of the MMC card slot switch
> * (there should be two card slots which are multiplexed to a single MMC
> diff --git a/hw/sd/sd.c b/hw/sd/sd.c
> index 9ac9b63ff8..72d32f7845 100644
> --- a/hw/sd/sd.c
> +++ b/hw/sd/sd.c
> @@ -1885,7 +1885,7 @@ uint8_t sd_read_data(SDState *sd)
> return ret;
> }
>
> -bool sd_data_ready(SDState *sd)
> +static bool sd_data_ready(SDState *sd)
> {
> return sd->state == sd_sendingdata_state;
> }
> --
> 2.16.1
>
>
- [Qemu-devel] [PATCH v3 0/7] SDHCI: convert legacy devices to the SDBus API (part 6), Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [PATCH v3 1/7] hw/sd/milkymist-memcard: use qemu_log_mask(), Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [PATCH v3 2/7] hw/sd/milkymist-memcard: split realize() out of SysBusDevice init(), Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [PATCH v3 3/7] hw/sd/milkymist-memcard: expose a SDBus and connect the SDCard to it, Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [PATCH v3 4/7] hw/sd/ssi-sd: use the SDBus API, connect the SDCard to the bus, Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [RFC PATCH v3 5/7] hw/sd/pl181: expose a SDBus and connect the SDCard to it, Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [PATCH v3 6/7] hw/sd: make sd_data_ready() static, Philippe Mathieu-Daudé, 2018/02/15
- Re: [Qemu-devel] [PATCH v3 6/7] hw/sd: make sd_data_ready() static,
Alistair Francis <=
- [Qemu-devel] [PATCH v3 7/7] hw/sd: move sdcard legacy API to "hw/sd/sdcard_legacy.h", Philippe Mathieu-Daudé, 2018/02/15
- Re: [Qemu-devel] [PATCH v3 0/7] SDHCI: convert legacy devices to the SDBus API (part 6), Peter Maydell, 2018/02/22