Re: [Qemu-devel] [PATCH] docs: pcie: Spell out machine type needs for PCIe features

[Daniel P . Berrangé]

On Mon, Feb 19, 2018 at 04:43:33PM +0100, Kashyap Chamarthy wrote:
> PCIe features are available only via the Q35 machine for x86, or the
> 'virt' machine type for AArch64 architecture.
> 
> Mention that explicitly.
> 
> Thanks: Daniel Berrangé
> 
> Signed-off-by: Kashyap Chamarthy <address@hidden>
> ---
>  docs/pcie.txt | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/docs/pcie.txt b/docs/pcie.txt
> index 8d3694970e..3e5bf52e0b 100644
> --- a/docs/pcie.txt
> +++ b/docs/pcie.txt
> @@ -3,8 +3,14 @@ PCI EXPRESS GUIDELINES
>  
>  1. Introduction
>  ================
> -The doc proposes best practices on how to use PCI Express/PCI device
> -in PCI Express based machines and explains the reasoning behind them.
> +The doc proposes best practices on how to use PCI Express (PCIe) / PCI
> +device in PCI Express based machines and explains the reasoning behind
> +them.

Pre-existing bug  s/device/devices/

> +This applies to the Q35 machine type on x86 and the 'virt' machine type

For consistency I'd suggest  'q35' rather than Q35.

> +on AArch64 (in other words, PCIe features are available only when using
> +the Q35 and 'virt' machine types for the said architectures). Other

And again, though I feel the stuff in (...) is just repeating what's
said in the stuff either side of the brackets.

> +machine types do not use PCI Express at this time.
>  
>  The following presentations accompany this document:
>   (1) Q35 overview.
> -- 
> 2.13.6
> 

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|