[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 7/8] net: Add a new convenience option "-n" t
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v1 7/8] net: Add a new convenience option "-n" to configure default/on-board NICs |
Date: |
Mon, 19 Feb 2018 17:20:14 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 19/02/2018 10:15, Thomas Huth wrote:
> The legacy "-net" option can be quite confusing for the users since most
> people do not expect to get a "vlan" hub between their emulated guest
> hardware and the host backend. But so far, we are also not able to get
> rid of "-net" completely, since it is the only way to configure on-board
> NICs that can not be instantiated via "-device" yet. It's also a little
> bit shorter to type "-net nic -net tap" instead of "-device xyz,netdev=n1
> -netdev tap,id=n1".
>
> So what we need is a new convenience option that is shorter to type than
> the full -device + -netdev stuff, and which can be used to configure the
> on-board NICs that can not be handled via -device yet. Thus this patch now
> provides such a new option "-n": It adds an entry in the nd_table to
> configure a on-board / default NIC, creates a host backend and connects
> the two directly, without a confusing "vlan" hub inbetween.
Sorry for the bikeshedding, but... perhaps "-n" is a bit bold. While I
initially couldn't come up with a better one, after putting some thought
into it "-nic" came to mind. There's precedent in naming the option for
the *front-end* device that it creates, whereas the arguments define
either the front-end (e.g. "model") or the back-end; see for example
"-drive". "-nic tap,model=e1000" and "-nic none" both make nice sense.
Thanks,
Paolo
- [Qemu-devel] [PATCH v1 3/8] net: Only show vhost-user in the help text if CONFIG_POSIX is defined, (continued)
- [Qemu-devel] [PATCH v1 3/8] net: Only show vhost-user in the help text if CONFIG_POSIX is defined, Thomas Huth, 2018/02/19
- [Qemu-devel] [PATCH v1 4/8] net: Make net_client_init() static, Thomas Huth, 2018/02/19
- [Qemu-devel] [PATCH v1 5/8] net: Remove the deprecated way of dumping network packets, Thomas Huth, 2018/02/19
- [Qemu-devel] [PATCH v1 6/8] net: Remove the deprecated 'host_net_add' and 'host_net_remove' HMP commands, Thomas Huth, 2018/02/19
- [Qemu-devel] [PATCH v1 7/8] net: Add a new convenience option "-n" to configure default/on-board NICs, Thomas Huth, 2018/02/19
- Re: [Qemu-devel] [PATCH v1 7/8] net: Add a new convenience option "-n" to configure default/on-board NICs,
Paolo Bonzini <=
- [Qemu-devel] [PATCH v1 8/8] qemu-doc: Make "-net" less prominent, Thomas Huth, 2018/02/19
- Re: [Qemu-devel] [PATCH v1 0/8] Improvements and clean-ups related to -net, Eric Blake, 2018/02/19