Re: [Qemu-devel] [PATCH 1/2] translator: pass max_insns to tb_start

[Richard Henderson]

On 02/15/2018 07:18 PM, Emilio G. Cota wrote:
> sh4 will need it.
> 
> Signed-off-by: Emilio G. Cota <address@hidden>
> ---
>  accel/tcg/translator.c     | 2 +-
>  include/exec/translator.h  | 3 ++-
>  target/alpha/translate.c   | 3 ++-
>  target/arm/translate-a64.c | 4 +++-
>  target/arm/translate.c     | 4 +++-
>  target/hppa/translate.c    | 4 +++-
>  target/i386/translate.c    | 3 ++-
>  7 files changed, 16 insertions(+), 7 deletions(-)

There is another possibility, which is to move max_insns into DisasContextBase
where it can be modified.  This would allow the gusa sequence to be handled
differently as an instance of the translate_insn hook, which would allow a
breakpoint to be placed on the first insn of a gusa sequence.

I guess I don't have strong feelings either way.

Reviewed-by: Richard Henderson <address@hidden>


r~