[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] util/uri.c formating
|
From: |
Thomas Huth |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] util/uri.c formating |
|
Date: |
Tue, 20 Feb 2018 09:39:14 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 20.02.2018 09:02, Su Hang wrote:
> Formating the code with `clang-format -i util/uri.c`.
> My .clang-format file content is:
> '''
> IndentWidth: 4
> BreakBeforeBraces: Linux
> '''
>
> Then use `perl -pi -e "s/return \((.*?)\);/return \1;/g" util/uri.c`
> to remove pattern like this: "return (1);"
The patch does not apply on git master ... did you do this on top of
your previous patch? If so, please create a patch against the git master
branch instead.
> checkpatch.pl still rise these two kinds of "ERROR", I'm not sure
> whether I should also suppress these, so I left it.
I think it's OK if you ignore those errors for now.
Thomas