[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Document --rtc-td-hack, --localtime and --start
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] Document --rtc-td-hack, --localtime and --startdate as deprecated |
Date: |
Tue, 20 Feb 2018 16:05:15 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 20/02/2018 16:01, Thomas Huth wrote:
> These options have been marked in a comment in qemu-options.hx as
> deprecated in 2009 already (see commit 1ed2fc1fa35fadc0d6), but we
> never informed the users about these deprecations. Let's catch up
> on that omission now.
>
> Signed-off-by: Thomas Huth <address@hidden>
> ---
> qemu-doc.texi | 13 +++++++++++++
> vl.c | 5 +++++
> 2 files changed, 18 insertions(+)
>
> diff --git a/qemu-doc.texi b/qemu-doc.texi
> index 2f19980..7494042 100644
> --- a/qemu-doc.texi
> +++ b/qemu-doc.texi
> @@ -2736,6 +2736,19 @@ filesystem test suite. Also it requires the
> CAP_DAC_READ_SEARCH capability,
> which is not the recommended way to run QEMU. This backend should not be
> used and it will be removed with no replacement.
>
> address@hidden -rtc-td-hack (since 2.12.0)
> +
> +The @code{--rtc-td-hack} option has been replaced by
> address@hidden driftfix=slew}.
> +
> address@hidden -localtime (since 2.12.0)
> +
> +The @code{--localtime} option has been replaced by @code{--rtc localtime}.
> +
> address@hidden -startdate (since 2.12.0)
> +
> +The @code{--startdate} option has been replaced by @code{--rtc @var{date}}.
> +
> @section qemu-img command line arguments
>
> @subsection convert -s (since 2.0.0)
> diff --git a/vl.c b/vl.c
> index 0feaca7..84121bf 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3417,6 +3417,8 @@ int main(int argc, char **argv, char **envp)
> break;
> case QEMU_OPTION_localtime:
> rtc_utc = 0;
> + warn_report("This option is deprecated, "
> + "use '--rtc localtime' instead.");
> break;
> case QEMU_OPTION_vga:
> vga_model = optarg;
> @@ -3672,6 +3674,8 @@ int main(int argc, char **argv, char **envp)
> };
>
> qdev_prop_register_global(&slew_lost_ticks);
> + warn_report("This option is deprecated, "
> + "use '--rtc driftfix=slew' instead.");
> break;
> }
> case QEMU_OPTION_acpitable:
> @@ -3876,6 +3880,7 @@ int main(int argc, char **argv, char **envp)
> */
> break;
> case QEMU_OPTION_startdate:
> + warn_report("This option is deprecated, use '--rtc'
> instead.");
> configure_rtc_date_offset(optarg, 1);
> break;
> case QEMU_OPTION_rtc:
>
Queued, thanks.
paolo
- Re: [Qemu-devel] [PATCH] Document --rtc-td-hack, --localtime and --startdate as deprecated,
Paolo Bonzini <=