[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 19/20] tcg/i386: Add vector operations
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PULL 19/20] tcg/i386: Add vector operations |
Date: |
Tue, 20 Feb 2018 17:44:08 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 2018-02-07 23:55, Richard Henderson wrote:
> The x86 vector instruction set is extremely irregular. With newer
> editions, Intel has filled in some of the blanks. However, we don't
> get many 64-bit operations until SSE4.2, introduced in 2009.
>
> The subsequent edition was for AVX1, introduced in 2011, which added
> three-operand addressing, and adjusts how all instructions should be
> encoded.
>
> Given the relatively narrow 2 year window between possible to support
> and desirable to support, and to vastly simplify code maintainence,
> I am only planning to support AVX1 and later cpus.
>
> Reviewed-by: Alex Bennée <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> tcg/i386/tcg-target.h | 41 +-
> tcg/i386/tcg-target.opc.h | 13 +
> tcg/i386/tcg-target.inc.c | 987
> +++++++++++++++++++++++++++++++++++++++++++---
> 3 files changed, 987 insertions(+), 54 deletions(-)
> create mode 100644 tcg/i386/tcg-target.opc.h
This patch makes make check with clang -m32 fail for me. (Interestingly
enough, though, clang -m64 and gcc -m32 work fine.)
GTESTER check-qtest-x86_64
qemu-system-x86_64: tcg/tcg.c:1928: void process_op_defs(TCGContext *):
Assertion `tdefs != ((void*)0)' failed.
socket_accept failed: Resource temporarily unavailable
**
ERROR:tests/libqtest.c:218:qtest_init_without_qmp_handshake: assertion
failed: (s->fd >= 0 && s->qmp_fd >= 0)
GTester: last random seed: R02Sd65222fb9e582d96aaa44bfe71602302
qemu-system-x86_64: tcg/tcg.c:1928: void process_op_defs(TCGContext *):
Assertion `tdefs != ((void*)0)' failed.
socket_accept failed: Resource temporarily unavailable
**
ERROR:tests/libqtest.c:218:qtest_init_without_qmp_handshake: assertion
failed: (s->fd >= 0 && s->qmp_fd >= 0)
GTester: last random seed: R02S244a2da30d9373db0cf52cd40f1b726a
(This is with the tdefs != NULL assertion enabled; usually, the qemu
process just crashes instead of printing that assertion failure message.)
Max
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PULL 13/20] target/arm: Use vector infrastructure for aa64 mov/not/neg, (continued)
- [Qemu-devel] [PULL 13/20] target/arm: Use vector infrastructure for aa64 mov/not/neg, Richard Henderson, 2018/02/07
- [Qemu-devel] [PULL 09/20] tcg: Add generic vector helpers with a scalar operand, Richard Henderson, 2018/02/07
- [Qemu-devel] [PULL 04/20] tcg: Add generic vector expanders, Richard Henderson, 2018/02/07
- [Qemu-devel] [PULL 12/20] target/arm: Use vector infrastructure for aa64 add/sub/logic, Richard Henderson, 2018/02/07
- [Qemu-devel] [PULL 14/20] target/arm: Use vector infrastructure for aa64 dup/movi, Richard Henderson, 2018/02/07
- [Qemu-devel] [PULL 18/20] target/arm: Use vector infrastructure for aa64 orr/bic immediate, Richard Henderson, 2018/02/07
- [Qemu-devel] [PULL 16/20] target/arm: Use vector infrastructure for aa64 compares, Richard Henderson, 2018/02/07
- [Qemu-devel] [PULL 17/20] target/arm: Use vector infrastructure for aa64 multiplies, Richard Henderson, 2018/02/07
- [Qemu-devel] [PULL 15/20] target/arm: Use vector infrastructure for aa64 constant shifts, Richard Henderson, 2018/02/07
- [Qemu-devel] [PULL 19/20] tcg/i386: Add vector operations, Richard Henderson, 2018/02/07
- Re: [Qemu-devel] [PULL 19/20] tcg/i386: Add vector operations,
Max Reitz <=
- [Qemu-devel] [PULL 20/20] tcg/aarch64: Add vector operations, Richard Henderson, 2018/02/07
- Re: [Qemu-devel] [PULL 00/20] tcg: generic vector operaions, no-reply, 2018/02/07
- Re: [Qemu-devel] [PULL 00/20] tcg: generic vector operaions, Peter Maydell, 2018/02/08