Re: [Qemu-devel] [PATCH v7 10/23] qmp: introduce QMPCapability

[Peter Xu]

On Wed, Feb 21, 2018 at 04:17:18PM +0000, Stefan Hajnoczi wrote:
> On Wed, Jan 24, 2018 at 01:39:44PM +0800, Peter Xu wrote:
> > diff --git a/qapi-schema.json b/qapi-schema.json
> > index 5c06745c79..2490d5188e 100644
> > --- a/qapi-schema.json
> > +++ b/qapi-schema.json
> > @@ -102,21 +102,47 @@
> >  #
> >  # Enable QMP capabilities.
> >  #
> > -# Arguments: None.
> > +# Arguments:
> > +#
> > +# @enable:    List of QMPCapabilities to enable, which is optional.
> > +#             Client must not enable any capability that is not
> > +#             mentioned in QMP greeting message.
> 
> qapi-schema.json uses full sentences so I've added missing articles to
> the text.  I also changed s/QMPCapabilities/QMPCapability values/ to
> avoid confusion about the type name:
> 
>   An optional list of QMPCapability values to enable.  The client must
>   not enable any capability that is not mentioned in the QMP greeting
>   message.
> 
> >  #
> >  # Example:
> >  #
> > -# -> { "execute": "qmp_capabilities" }
> > +# -> { "execute": "qmp_capabilities",
> > +#      "arguments": { "enable": [ "oob" ] } }
> >  # <- { "return": {} }
> >  #
> >  # Notes: This command is valid exactly when first connecting: it must be
> >  # issued before any other command will be accepted, and will fail once the
> >  # monitor is accepting other commands. (see qemu docs/interop/qmp-spec.txt)
> >  #
> > +# QMP client needs to explicitly enable QMP capabilities, otherwise
> 
> s/QMP client/The QMP client/

Thanks;  Fixing them all.

-- 
Peter Xu