[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 06/11] sdcard: do not trace CMD55 when expect
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v4 06/11] sdcard: do not trace CMD55 when expecting ACMD |
Date: |
Thu, 22 Feb 2018 12:01:40 +0000 |
On 15 February 2018 at 22:05, Philippe Mathieu-Daudé <address@hidden> wrote:
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> Acked-by: Alistair Francis <address@hidden>
> ---
> hw/sd/sd.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/hw/sd/sd.c b/hw/sd/sd.c
> index 564f7a9bfd..af4df2b104 100644
> --- a/hw/sd/sd.c
> +++ b/hw/sd/sd.c
> @@ -818,13 +818,15 @@ static void sd_lock_command(SDState *sd)
> sd->card_status &= ~CARD_IS_LOCKED;
> }
>
> -static sd_rsp_type_t sd_normal_command(SDState *sd,
> - SDRequest req)
> +static sd_rsp_type_t sd_normal_command(SDState *sd, SDRequest req)
> {
> uint32_t rca = 0x0000;
> uint64_t addr = (sd->ocr & (1 << 30)) ? (uint64_t) req.arg << 9 :
> req.arg;
>
> - trace_sdcard_normal_command(req.cmd, req.arg, sd_state_name(sd->state));
> + if (req.cmd != 55 || sd->expecting_acmd) {
> + trace_sdcard_normal_command(req.cmd, req.arg,
> + sd_state_name(sd->state));
> + }
The commit message says "don't trace CMD55 when expecting ACMD",
but the code says "don't trace CMD55 when *not* expecting ACMD" --
which is correct?
thanks
-- PMM
- [Qemu-devel] [PATCH v4 00/11] SDCard: housekeeping, add tracing (part 4), Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [PATCH v4 01/11] sdcard: reorder SDState struct members, Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [PATCH v4 02/11] sdcard: replace DPRINTF() by trace events, Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [PATCH v4 03/11] sdcard: add a trace event for command responses, Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [PATCH v4 04/11] sdcard: replace fprintf() by qemu_hexdump(), Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [PATCH v4 05/11] sdcard: add more trace events, Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [PATCH v4 06/11] sdcard: do not trace CMD55 when expecting ACMD, Philippe Mathieu-Daudé, 2018/02/15
- Re: [Qemu-devel] [PATCH v4 06/11] sdcard: do not trace CMD55 when expecting ACMD,
Peter Maydell <=
- [Qemu-devel] [PATCH v4 07/11] sdcard: define SDMMC_CMD_MAX instead of using the magic '64', Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [PATCH v4 08/11] sdcard: display command name when tracing CMD/ACMD, Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [PATCH v4 09/11] sdcard: display protocol used when tracing, Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [PATCH v4 10/11] sdcard: use G_BYTE from cutils, Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [PATCH v4 11/11] sdcard: use the registerfields API to access the OCR register, Philippe Mathieu-Daudé, 2018/02/15
- Re: [Qemu-devel] [PATCH v4 00/11] SDCard: housekeeping, add tracing (part 4), Philippe Mathieu-Daudé, 2018/02/22
- Re: [Qemu-devel] [PATCH v4 00/11] SDCard: housekeeping, add tracing (part 4), Peter Maydell, 2018/02/22