[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 01/26] block/mirror: Small absolute-paths sim
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v8 01/26] block/mirror: Small absolute-paths simplification |
Date: |
Thu, 22 Feb 2018 13:27:00 +0100 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
Am 05.02.2018 um 16:18 hat Max Reitz geschrieben:
> When invoking drive-mirror in absolute-paths mode, the target's backing
> BDS is assigned to it in mirror_exit(). The current logic only does so
> if the target does not have that backing BDS already; but it actually
> cannot have a backing BDS at all (the BDS is opened with O_NO_BACKING in
> qmp_drive_mirror()), so just assert that and assign the new backing BDS
> unconditionally.
>
> Signed-off-by: Max Reitz <address@hidden>
> Reviewed-by: Alberto Garcia <address@hidden>
Introducing new assumptions that the graph stays unmodified between the
start of a block job and its completion feels a bit adventurous when all
of the blockdev work is moving towards making things more flexible.
If we really do want to enforce this, I guess you finally found a use
case for BLK_PERM_GRAPH_MOD.
Kevin
- [Qemu-devel] [PATCH v8 00/26] block: Fix some filename generation issues, Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 01/26] block/mirror: Small absolute-paths simplification, Max Reitz, 2018/02/05
- Re: [Qemu-devel] [PATCH v8 01/26] block/mirror: Small absolute-paths simplification,
Kevin Wolf <=
- [Qemu-devel] [PATCH v8 02/26] block: Use children list in bdrv_refresh_filename, Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 03/26] block: Add BDS.backing_overridden, Max Reitz, 2018/02/05
- Re: [Qemu-devel] [PATCH v8 03/26] block: Add BDS.backing_overridden, Kevin Wolf, 2018/02/22
- Re: [Qemu-devel] [PATCH v8 03/26] block: Add BDS.backing_overridden, Max Reitz, 2018/02/22
- Re: [Qemu-devel] [PATCH v8 03/26] block: Add BDS.backing_overridden, Kevin Wolf, 2018/02/22
- Re: [Qemu-devel] [PATCH v8 03/26] block: Add BDS.backing_overridden, Max Reitz, 2018/02/22
- Re: [Qemu-devel] [PATCH v8 03/26] block: Add BDS.backing_overridden, Kevin Wolf, 2018/02/22
- Re: [Qemu-devel] [PATCH v8 03/26] block: Add BDS.backing_overridden, Max Reitz, 2018/02/22