[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 09/11] sdcard: display protocol used when tra
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH v4 09/11] sdcard: display protocol used when tracing |
|
Date: |
Thu, 22 Feb 2018 13:02:22 +0000 |
On 15 February 2018 at 22:05, Philippe Mathieu-Daudé <address@hidden> wrote:
> put the function in sdmmc-common.c since we will reuse it in hw/sd/core.c
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Commit message talks about a function but the patch doesn't
add any new functions ? (Also, sentences should start with
a capital letter and end with a full stop, please.)
Otherwise
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- Re: [Qemu-devel] [PATCH v4 02/11] sdcard: replace DPRINTF() by trace events, (continued)
- [Qemu-devel] [PATCH v4 03/11] sdcard: add a trace event for command responses, Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [PATCH v4 04/11] sdcard: replace fprintf() by qemu_hexdump(), Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [PATCH v4 05/11] sdcard: add more trace events, Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [PATCH v4 06/11] sdcard: do not trace CMD55 when expecting ACMD, Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [PATCH v4 07/11] sdcard: define SDMMC_CMD_MAX instead of using the magic '64', Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [PATCH v4 08/11] sdcard: display command name when tracing CMD/ACMD, Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [PATCH v4 09/11] sdcard: display protocol used when tracing, Philippe Mathieu-Daudé, 2018/02/15
- Re: [Qemu-devel] [PATCH v4 09/11] sdcard: display protocol used when tracing,
Peter Maydell <=
- [Qemu-devel] [PATCH v4 10/11] sdcard: use G_BYTE from cutils, Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [PATCH v4 11/11] sdcard: use the registerfields API to access the OCR register, Philippe Mathieu-Daudé, 2018/02/15
- Re: [Qemu-devel] [PATCH v4 00/11] SDCard: housekeeping, add tracing (part 4), Philippe Mathieu-Daudé, 2018/02/22
- Re: [Qemu-devel] [PATCH v4 00/11] SDCard: housekeeping, add tracing (part 4), Peter Maydell, 2018/02/22