Re: [Qemu-devel] [RFC PATCH 0/5] ui: add keyboard state and hotkey tracker

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [RFC PATCH 0/5] ui: add keyboard state and hotkey tracker

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
9065fbc367 sdl2: use only QKeyCode in sdl2_process_key()
0c65c8c6bb kbd-state: register sdl2 hotkeys
67a2d8cd4a kbd-state: use state tracker for sdl2
a389e7e994 kbd-state: add hotkey registry
d14a0b4fd8 kbd-state: add keyboard state tracker

=== OUTPUT BEGIN ===
Checking PATCH 1/5: kbd-state: add keyboard state tracker...
ERROR: space required after that ',' (ctx:BxV)
#86: FILE: ui/kbd-state.c:22:
+    QTAILQ_HEAD(,KbdHotkey) hotkeys;
                 ^

total: 1 errors, 0 warnings, 149 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/5: kbd-state: add hotkey registry...
Checking PATCH 3/5: kbd-state: use state tracker for sdl2...
Checking PATCH 4/5: kbd-state: register sdl2 hotkeys...
Checking PATCH 5/5: sdl2: use only QKeyCode in sdl2_process_key()...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden