[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] tcg: Add missing tcg_can_emit_vec_op check
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/2] tcg: Add missing tcg_can_emit_vec_op check in tcg_gen_gvec_2s |
|
Date: |
Thu, 22 Feb 2018 07:32:25 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 02/22/2018 06:58 AM, Peter Maydell wrote:
> Incidentally, I notice that the condition checks
> (TCG_TARGET_HAS_v256 && check_size_impl(oprsz, 32)
> && tcg_can_emit_vec_op(g->opc, TCG_TYPE_V256, g->vece))
>
> (TCG_TARGET_HAS_v128 && check_size_impl(oprsz, 16)
> && tcg_can_emit_vec_op(g->opc, TCG_TYPE_V128, g->vece))
>
> (TCG_TARGET_HAS_v64 && check_size_impl(oprsz, 8)
> && tcg_can_emit_vec_op(g->opc, TCG_TYPE_V64, g->vece))
>
> seem to be quite commonly used -- perhaps factoring these out
> into suitably named functions would make the code more readable?
That's a good idea. I'll see what I can come up with there.
r~