Re: [Qemu-devel] [PATCH v2 14/67] target/arm: Implement SVE Integer Arithmetic - Unary Predicated Group

[Peter Maydell]

On 17 February 2018 at 18:22, Richard Henderson
<address@hidden> wrote:
> Signed-off-by: Richard Henderson <address@hidden>
> ---
>  target/arm/helper-sve.h    |  60 +++++++++++++++++++++
>  target/arm/sve_helper.c    | 127 
> +++++++++++++++++++++++++++++++++++++++++++++
>  target/arm/translate-sve.c | 111 +++++++++++++++++++++++++++++++++++++++
>  target/arm/sve.decode      |  23 ++++++++
>  4 files changed, 321 insertions(+)

> diff --git a/target/arm/sve.decode b/target/arm/sve.decode
> index 177f338fed..b875501475 100644
> --- a/target/arm/sve.decode
> +++ b/target/arm/sve.decode
> @@ -165,6 +165,29 @@ ASR_zpzw   00000100 .. 011 000 100 ... ..... .....       
>   @rdn_pg_rm
>  LSR_zpzw       00000100 .. 011 001 100 ... ..... .....         @rdn_pg_rm
>  LSL_zpzw       00000100 .. 011 011 100 ... ..... .....         @rdn_pg_rm
>
> +### SVE Integer Arithmetic - Unary Predicated Group
> +
> +# SVE unary bit operations (predicated)
> +# Note esz != 0 for FABS and FNEG.
> +CLS            00000100 .. 011 000 101 ... ..... .....         @rd_pg_rn
> +CLZ            00000100 .. 011 001 101 ... ..... .....         @rd_pg_rn
> +CNT_zpz                00000100 .. 011 010 101 ... ..... .....         
> @rd_pg_rn
> +CNOT           00000100 .. 011 011 101 ... ..... .....         @rd_pg_rn
> +NOT_zpz                00000100 .. 011 110 101 ... ..... .....         
> @rd_pg_rn
> +FABS           00000100 .. 011 100 101 ... ..... .....         @rd_pg_rn
> +FNEG           00000100 .. 011 101 101 ... ..... .....         @rd_pg_rn

Indentation seems to be a bit skew for the _zpz lines.

Otherwise
Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM