qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 4/6] vhost-user-test: do not hang if chardev cre


From: Maxime Coquelin
Subject: Re: [Qemu-devel] [PATCH 4/6] vhost-user-test: do not hang if chardev creation failed
Date: Fri, 23 Feb 2018 15:16:05 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0



On 02/15/2018 10:25 PM, Marc-André Lureau wrote:
Before the chardev name fix, the following error may happen: "attempt
to add duplicate property 'chr-test' to object (type 'container')",
due to races.

Sadly, error_vprintf() uses g_test_message(), so you have to use
read the cryptic --debug-log to see it. Later, it would make sense to
use g_critical() instead, and catch errors with
g_test_expect_message() (in glib 2.34).

Signed-off-by: Marc-André Lureau <address@hidden>
---
  tests/vhost-user-test.c | 1 +
  1 file changed, 1 insertion(+)
Acked-by: Maxime Coquelin <address@hidden>

Thanks,
Maxime



reply via email to

[Prev in Thread] Current Thread [Next in Thread]