Re: [Qemu-devel] [PATCH v3 14/31] arm/translate-a64: add FP16 FMULX/MLS/FMLA to simd_indexed

[Richard Henderson]

On 02/23/2018 07:36 AM, Alex Bennée wrote:
>      case 0x9: /* FMUL, FMULX */
> -        if (!extract32(size, 1, 1)) {
> +        if (size == 1 ||
> +            (size < 2 && !arm_dc_feature(s, ARM_FEATURE_V8_FP16))) {
>              unallocated_encoding(s);

You get to drop the check here...

> +        case 0: /* half precision */
> +            size = MO_16;
> +            index = h << 2 | l << 1 | m;
> +            is_fp16 = true;
> +            if (arm_dc_feature(s, ARM_FEATURE_V8_FP16)) {
> +                break;
> +            }

... because you added it here instead.


r~