[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/4] qcow2: Document some maximum size constr
|
From: |
Alberto Garcia |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 2/4] qcow2: Document some maximum size constraints |
|
Date: |
Mon, 26 Feb 2018 17:46:44 +0100 |
|
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Mon 26 Feb 2018 05:41:54 PM CET, Eric Blake wrote:
>> But refcount blocks are not addressed by L2 tables, so in principle
>> it should be possible to have refcount blocks after the first 64PB.
>
> But (if we don't make this change) that's about all you can usefully
> have (and it would be a self-referencing refcount block).
Yeah, true.
>>> + 56 - 63: Reserved (set to 0)
>>
>> Are we not updating REFT_OFFSET_MASK as well?
>
> We could, but that should be a separate patch from the spec change.
> We could also add some validation that any offsets in the header point
> to less than the 64PB limit.
Ok, let's leave that for another patch then.
Reviewed-by: Alberto Garcia <address@hidden>
Berto
[Qemu-devel] [PATCH v3 4/4] qcow2: Avoid memory over-allocation on compressed images, Eric Blake, 2018/02/22
[Qemu-devel] [PATCH v3 3/4] qcow2: Don't allow overflow during cluster allocation, Eric Blake, 2018/02/22