|
From: | Jason Wang |
Subject: | Re: [Qemu-devel] [PATCH] net: Move the toeplitz functions from checksum.h to net_rx_pkt.c |
Date: | Tue, 27 Feb 2018 15:55:32 +0800 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 2018年02月22日 17:04, Thomas Huth wrote:
The functions are only used in this single .c file, so there is no need to put all this code in a header that is included from multiple places. Signed-off-by: Thomas Huth<address@hidden> --- hw/net/net_rx_pkt.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ include/net/checksum.h | 44 -------------------------------------------- 2 files changed, 44 insertions(+), 44 deletions(-)
Hi Thomas,We have plan to implement RSS for virtio-net, so it looks like we'd better keep it in the header.
Thanks
[Prev in Thread] | Current Thread | [Next in Thread] |