Re: [Qemu-devel] [RFC v4 01/21] blockjobs: fix set-speed kick

[Eric Blake]

On 02/23/2018 05:51 PM, John Snow wrote:
> If speed is '0' it's not actually "less than" the previous speed.
> Kick the job in this case too.
>
> Signed-off-by: John Snow <address@hidden>
> ---
>   blockjob.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Eric Blake <address@hidden>

> diff --git a/blockjob.c b/blockjob.c
> index 3f52f29f75..24833ef30f 100644
> --- a/blockjob.c
> +++ b/blockjob.c
> @@ -499,7 +499,7 @@ void block_job_set_speed(BlockJob *job, int64_t speed, 
> Error **errp)
>       }
>   
>       job->speed = speed;
> -    if (speed <= old_speed) {
> +    if (speed && speed <= old_speed) {
>           return;
>       }
>   

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org