Re: [Qemu-devel] [PATCH] simpletrace: fix timestamp argument type

[Stefan Hajnoczi]

On Thu, Feb 22, 2018 at 04:39:01PM +0000, Stefan Hajnoczi wrote:
> The timestamp argument to a trace event method is documented as follows:
> 
>   The method can also take a timestamp argument before the trace event
>   arguments:
> 
>     def runstate_set(self, timestamp, new_state):
>         ...
> 
>   Timestamps have the uint64_t type and are in nanoseconds.
> 
> In reality methods with a timestamp argument actually receive a tuple
> like (123456789,) as the timestamp argument.  This is due to a bug in
> simpletrace.py.
> 
> This patch unpacks the tuple so that methods receive the correct
> timestamp argument type.
> 
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
>  scripts/simpletrace.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

The patchew error was bogus.

Thanks, applied to my tracing tree:
https://github.com/stefanha/qemu/commits/tracing

Stefan

signature.asc
Description: PGP signature