qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [Qemu-arm] [PATCH v4 00/31] Add ARMv8.2 half-precision


From: Peter Maydell
Subject: Re: [Qemu-devel] [Qemu-arm] [PATCH v4 00/31] Add ARMv8.2 half-precision functions
Date: Tue, 27 Feb 2018 18:11:57 +0000

On 27 February 2018 at 14:38, Alex Bennée <address@hidden> wrote:
> A few minor fixes and a chunk of Richard's r-b tags. Now all that is
> left is:
>
>   patch 0014/arm translate a64 add FP16 FMULX MLS FMLA to simd.patch needs 
> review
>
> Otherwise see comments bellow --- for other changes
>

Thanks -- applied to target-arm.next. Some caveats:

(1) we can fix the nit RTH noted about FMULX later

(2) I notice that there's no patch here that adds the linux-user/elfload.c
code to set a hwcap for the guest program to indicate FP16 presence.
Presumably there is such a hwcap?

(3) Is this complete fp16 support or are there still more pieces to come?
I'm assuming it's all done...

(4) I've split the "add new ARM_V8_FP16 feature bit to the enum"
and "enable the feature on the 'any' CPU" parts of patch 2, so
we can do the latter at the end. If there is still missing parts
to fp16 then we can drop the enable-feature half of that
for the moment.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]