[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 00/14] qio: general non-default GMainContext support
From: |
Peter Xu |
Subject: |
[Qemu-devel] [PATCH 00/14] qio: general non-default GMainContext support |
Date: |
Wed, 28 Feb 2018 13:06:19 +0800 |
This is another preparation work for monitor OOB seires.
This series tries to allow QIO code to run with non-default
GMainContext. Note that for most places I kept the old code
untouched, and only modified/introduced new interfaces where there can
be a non-default GMainContext. The "where" is mostly migration and
chardev submodules, since these two parts of code can be run with
monitor IOThread in the future (which holds a non-default
GMainContext).
These are existing known issue to be solved with GSources that bound
to main thread:
- migration
- incoming side: still always running on main context, while we need
to be able to run some command in OOB thread [1]
- tcp chardev (non-tcp chardevs should all support non-NULL context now)
- server listening mode: QIO net listener used [2]
- TELNET session: an isolated GSource used (tcp_chr_telnet_init) [3]
- when "reconnect=N" is used, QIO threaded task is used [4]
- TLS session: QIO tls handshake is used (tcp_chr_tls_init) [5]
Patch 1-2 are cleanups and fixes.
Patch 3 introduced qio_channel_add_watch_full(), which is the core API
for QIO to support non-default context.
Patch 4 fixes the migration usage of QIO, which is problem [1] above.
Patch 5-7 fixes the net listeners to use non-default gcontext, which
solves problem [2] above.
Patch 8 fixes the TELNET GSource, which solves problem [3].
Patch 9-13 fixes the threaded QIOTask usage, which is for problem [4].
Patch 14 fixes the last TLS usage, which is problem [5].
The whole series survives with "make check". There are quite a few
QIO tests there. Let's see whether this can be acceptable before more
tests.
Please review. Thanks.
Peter Xu (14):
chardev: fix leak in tcp_chr_telnet_init_io()
qio: rename qio_task_thread_result
qio: introduce qio_channel_add_watch_full()
migration: let incoming side use thread context
qio: refactor net listener source operations
qio: store gsources for net listeners
qio/chardev: update net listener gcontext
chardev: allow telnet gsource to switch gcontext
qio: basic non-default context support for thread
qio: refcount QIOTask
qio/chardev: return QIOTask when connect async
qio: move QIOTaskThreadData into QIOTask
qio: allow threaded qiotask to switch contexts
qio/chardev: specify gcontext for TLS handshake
chardev/char-socket.c | 114 ++++++++++++++++++++++++++-------
include/io/channel-socket.h | 14 +++--
include/io/channel-tls.h | 22 ++++++-
include/io/channel.h | 31 ++++++++-
include/io/net-listener.h | 33 +++++++++-
include/io/task.h | 10 ++-
io/channel-socket.c | 21 ++++---
io/channel-tls.c | 91 ++++++++++++++++++++++-----
io/channel.c | 24 +++++--
io/dns-resolver.c | 3 +-
io/net-listener.c | 119 +++++++++++++++++++++--------------
io/task.c | 149 ++++++++++++++++++++++++++++++++++++--------
migration/exec.c | 11 ++--
migration/fd.c | 11 ++--
migration/socket.c | 12 ++--
tests/test-io-task.c | 2 +
16 files changed, 514 insertions(+), 153 deletions(-)
--
2.14.3
- [Qemu-devel] [PATCH 00/14] qio: general non-default GMainContext support,
Peter Xu <=
[Qemu-devel] [PATCH 04/14] migration: let incoming side use thread context, Peter Xu, 2018/02/28