[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 11/14] qio/chardev: return QIOTask when connect
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [Qemu-devel] [PATCH 11/14] qio/chardev: return QIOTask when connect async |
|
Date: |
Wed, 28 Feb 2018 09:20:47 +0000 |
|
User-agent: |
Mutt/1.9.2 (2017-12-15) |
On Wed, Feb 28, 2018 at 01:06:30PM +0800, Peter Xu wrote:
> Let qio_channel_socket_connect_async() return the created QIOTask object
> for the async connection. In tcp chardev, cache that in SocketChardev
> for further use. With the QIOTask refcount, this is pretty safe.
Why do you want to return QIOTask ? This is going against the intended
design pattern for QIOTask (that was based on that in GLib). The task
supposed to be an internal use only helper that callers should never
be touching until the completion callback is invoked.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [Qemu-devel] [PATCH 07/14] qio/chardev: update net listener gcontext, (continued)
[Qemu-devel] [PATCH 08/14] chardev: allow telnet gsource to switch gcontext, Peter Xu, 2018/02/28
[Qemu-devel] [PATCH 09/14] qio: basic non-default context support for thread, Peter Xu, 2018/02/28
[Qemu-devel] [PATCH 10/14] qio: refcount QIOTask, Peter Xu, 2018/02/28
[Qemu-devel] [PATCH 11/14] qio/chardev: return QIOTask when connect async, Peter Xu, 2018/02/28
- Re: [Qemu-devel] [PATCH 11/14] qio/chardev: return QIOTask when connect async,
Daniel P . Berrangé <=
[Qemu-devel] [PATCH 12/14] qio: move QIOTaskThreadData into QIOTask, Peter Xu, 2018/02/28
[Qemu-devel] [PATCH 13/14] qio: allow threaded qiotask to switch contexts, Peter Xu, 2018/02/28
[Qemu-devel] [PATCH 14/14] qio/chardev: specify gcontext for TLS handshake, Peter Xu, 2018/02/28