[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 04/15] migration: let incoming side use threa
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-devel] [PATCH v2 04/15] migration: let incoming side use thread context |
Date: |
Thu, 1 Mar 2018 16:03:44 +0000 |
User-agent: |
Mutt/1.9.2 (2017-12-15) |
On Thu, Mar 01, 2018 at 04:44:27PM +0800, Peter Xu wrote:
> The old incoming migration is running in main thread and default
> gcontext. With the new qio_channel_add_watch_full() we can now let it
> run in the thread's own gcontext (if there is one).
>
> Currently this patch does nothing alone. But when any of the incoming
> migration is run in another iothread (e.g., the upcoming migrate-recover
> command), this patch will bind the incoming logic to the iothread
> instead of the main thread (which may already get page faulted and
> hanged).
>
> RDMA is not considered for now since it's not even using the QIO watch
> framework at all.
>
> CC: Juan Quintela <address@hidden>
> CC: Dr. David Alan Gilbert <address@hidden>
> CC: Laurent Vivier <address@hidden>
> Signed-off-by: Peter Xu <address@hidden>
> ---
> migration/exec.c | 9 ++++-----
> migration/fd.c | 9 ++++-----
> migration/socket.c | 10 +++++-----
> 3 files changed, 13 insertions(+), 15 deletions(-)
This should probably just be in a separate series, since it does nothing
on its own, and nothing following in this series touches migration at all.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
[Qemu-devel] [PATCH v2 05/15] qio: refactor net listener source operations, Peter Xu, 2018/03/01