Re: [Qemu-devel] [PULL 00/24] ppc-for-2.12 queue 20180302

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PULL 00/24] ppc-for-2.12 queue 20180302

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
095d21f5da hw/ppc/spapr, e500: Use new property "stdout-path" for boot console
7d6a1dd15c ppc/spapr-caps: Define the pseries-2.12-sxxm machine type
999bec564d ppc/spapr-caps: Convert cap-ibs to custom spapr-cap
1d33cf761b ppc/spapr-caps: Convert cap-sbbc to custom spapr-cap
01713a39fa ppc/spapr-caps: Convert cap-cfpc to custom spapr-cap
72f591c292 ppc/spapr-caps: Add support for custom spapr_capabilities
049adc46e2 target/ppc: Check mask when setting cap_ppc_safe_indirect_branch
090171d0bf macio: remove macio_init() function
289bcaf956 macio: move setting of CUDA timebase frequency to 
macio_common_realize()
e64f8792ca mac_newworld: use object link to pass OpenPIC object to macio
e5cb278a20 openpic: move OpenPIC state and related definitions to openpic.h
900bb47ec1 openpic: move KVM-specific declarations into separate openpic_kvm.h 
file
ff67f82901 mac_oldworld: use object link to pass heathrow PIC object to macio
d7aafa6fbd macio: move macio related structures and defines into separate 
macio.h file
3385201518 heathrow: change heathrow_pic_init() to return the heathrow device
22792de824 heathrow: convert to trace-events
09a5429e27 heathrow: QOMify heathrow PIC
b98172e42c macio: move ESCC device within the macio device
6ed5797e86 macio: embed DBDMA device directly within macio
60140b2909 spapr: harden code that depends on VSMT
a39d4a9d54 spapr: register dummy ICPs later
a11e85de36 ppc: Add aCube Sam460ex board
474e1f78a0 ppc440: Add emulation of plb-pcix controller found in some 440 SoCs
a8181ab61c spapr: fix missing CPU core nodes in DT when running with TCG

=== OUTPUT BEGIN ===
Checking PATCH 1/24: spapr: fix missing CPU core nodes in DT when running with 
TCG...
Checking PATCH 2/24: ppc440: Add emulation of plb-pcix controller found in some 
440 SoCs...
Checking PATCH 3/24: ppc: Add aCube Sam460ex board...
Checking PATCH 4/24: spapr: register dummy ICPs later...
Checking PATCH 5/24: spapr: harden code that depends on VSMT...
Checking PATCH 6/24: macio: embed DBDMA device directly within macio...
Checking PATCH 7/24: macio: move ESCC device within the macio device...
Checking PATCH 8/24: heathrow: QOMify heathrow PIC...
Checking PATCH 9/24: heathrow: convert to trace-events...
Checking PATCH 10/24: heathrow: change heathrow_pic_init() to return the 
heathrow device...
Checking PATCH 11/24: macio: move macio related structures and defines into 
separate macio.h file...
Checking PATCH 12/24: mac_oldworld: use object link to pass heathrow PIC object 
to macio...
Checking PATCH 13/24: openpic: move KVM-specific declarations into separate 
openpic_kvm.h file...
Checking PATCH 14/24: openpic: move OpenPIC state and related definitions to 
openpic.h...
ERROR: "foo * bar" should be "foo *bar"
#250: FILE: include/hw/ppc/openpic.h:57:
+#define RAVEN_DBL_IRQ    (RAVEN_IPI_IRQ + (RAVEN_MAX_CPU * RAVEN_MAX_IPI))

total: 1 errors, 0 warnings, 353 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 15/24: mac_newworld: use object link to pass OpenPIC object to 
macio...
Checking PATCH 16/24: macio: move setting of CUDA timebase frequency to 
macio_common_realize()...
Checking PATCH 17/24: macio: remove macio_init() function...
Checking PATCH 18/24: target/ppc: Check mask when setting 
cap_ppc_safe_indirect_branch...
Checking PATCH 19/24: ppc/spapr-caps: Add support for custom 
spapr_capabilities...
Checking PATCH 20/24: ppc/spapr-caps: Convert cap-cfpc to custom spapr-cap...
ERROR: line over 90 characters
#50: FILE: hw/ppc/spapr_caps.c:254:
+    .help = "broken - no protection, workaround - workaround available, fixed 
- fixed in hardware",

ERROR: line over 90 characters
#64: FILE: hw/ppc/spapr_caps.c:266:
+        error_setg(errp, "Requested safe cache capability level not supported 
by kvm, try cap-cfpc=%s", cap_cfpc_possible.vals[kvm_val]);

total: 2 errors, 0 warnings, 58 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 21/24: ppc/spapr-caps: Convert cap-sbbc to custom spapr-cap...
ERROR: line over 90 characters
#26: FILE: hw/ppc/spapr_caps.c:273:
+    .help = "broken - no protection, workaround - workaround available, fixed 
- fixed in hardware",

ERROR: line over 90 characters
#40: FILE: hw/ppc/spapr_caps.c:285:
+        error_setg(errp, "Requested safe bounds check capability level not 
supported by kvm, try cap-sbbc=%s", cap_sbbc_possible.vals[kvm_val]);

total: 2 errors, 0 warnings, 36 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 22/24: ppc/spapr-caps: Convert cap-ibs to custom spapr-cap...
ERROR: line over 90 characters
#96: FILE: hw/ppc/spapr_caps.c:234:
+    .help = "broken - no protection, fixed-ibs - indirect branch 
serialisation, fixed-ccd - cache count disabled",

ERROR: line over 90 characters
#106: FILE: hw/ppc/spapr_caps.c:243:
+        error_setg(errp, "Requested safe indirect branch capability level 
\"workaround\" not valid, try cap-ibs=%s", cap_ibs_possible.vals[kvm_val]);

ERROR: line over 90 characters
#113: FILE: hw/ppc/spapr_caps.c:248:
+        error_setg(errp, "Requested safe indirect branch capability level not 
supported by kvm, try cap-ibs=%s", cap_ibs_possible.vals[kvm_val]);

WARNING: line over 80 characters
#122: FILE: hw/ppc/spapr_caps.c:304:
+        .description = "Indirect Branch Speculation (broken, fixed-ibs, 
fixed-ccd)",

total: 3 errors, 1 warnings, 151 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 23/24: ppc/spapr-caps: Define the pseries-2.12-sxxm machine 
type...
Checking PATCH 24/24: hw/ppc/spapr, e500: Use new property "stdout-path" for 
boot console...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden