[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 15/15] chardev: tcp: postpone TLS work until
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH v2 15/15] chardev: tcp: postpone TLS work until machine done |
Date: |
Fri, 2 Mar 2018 14:43:59 +0800 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Thu, Mar 01, 2018 at 06:37:47PM +0100, Paolo Bonzini wrote:
> On 01/03/2018 09:44, Peter Xu wrote:
> > +static bool tcp_chr_machine_done;
> > +
> > static void tcp_chr_reconn_timer_cancel(SocketChardev *s)
> > {
> > if (s->reconnect_timer) {
> > @@ -719,6 +721,11 @@ static void tcp_chr_tls_init(Chardev *chr)
> > Error *err = NULL;
> > gchar *name;
> >
> > + if (!tcp_chr_machine_done) {
> > + /* This will be postponed to machine_done notifier */
> > + return;
> > + }
> > +
>
> Can you instead add a global machine_init_done bool to vl.c and
> include/sysemu/sysemu.h (and make it always true in
> stubs/machine-init-done.c)?
>
> Then muxes_realized can go away too.
Sure! I'll add a new patch for it. Thanks,
--
Peter Xu
- [Qemu-devel] [PATCH v2 13/15] char: use chardev's gcontext for async connect, (continued)