[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/10] linux-user: init_guest_space: Clarify pag
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 05/10] linux-user: init_guest_space: Clarify page alignment logic |
Date: |
Fri, 2 Mar 2018 13:19:43 +0000 |
On 28 December 2017 at 18:08, Luke Shumaker <address@hidden> wrote:
> From: Luke Shumaker <address@hidden>
>
> There are 3 parts to this change:
> - Add a comment showing the relative sizes and positions of the blocks of
> memory
> - introduce and use new aligned_{start,size} instead of adjusting
> real_{start_size}
> - When we clean up (on failure), munmap(real_start, real_size) instead of
> munmap(aligned_start, aligned_size). It *shouldn't* make any
> difference, but I will admit that this does mean we are making the
> syscall with different values, so this isn't quite a no-op patch.
>
> Signed-off-by: Luke Shumaker <address@hidden>
> ---
> linux-user/elfload.c | 43 +++++++++++++++++++++++++++++++++----------
> 1 file changed, 33 insertions(+), 10 deletions(-)
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- Re: [Qemu-devel] [PATCH 05/10] linux-user: init_guest_space: Clarify page alignment logic,
Peter Maydell <=