[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] net: add e1000e model to the "simple" -net/
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] net: add e1000e model to the "simple" -net/-nic options |
Date: |
Fri, 2 Mar 2018 18:31:41 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 02/03/2018 18:19, Thomas Huth wrote:
> On 02.03.2018 16:51, Paolo Bonzini wrote:
>> Signed-off-by: Paolo Bonzini <address@hidden>
>> ---
>> hw/pci/pci.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/hw/pci/pci.c b/hw/pci/pci.c
>> index e006b6ac71..af3c85a46f 100644
>> --- a/hw/pci/pci.c
>> +++ b/hw/pci/pci.c
>> @@ -1822,6 +1822,7 @@ static const char * const pci_nic_models[] = {
>> "i82559er",
>> "rtl8139",
>> "e1000",
>> + "e1000e",
>> "pcnet",
>> "virtio",
>> "sungem",
>> @@ -1835,6 +1836,7 @@ static const char * const pci_nic_names[] = {
>> "i82559er",
>> "rtl8139",
>> "e1000",
>> + "e1000e",
>> "pcnet",
>> "virtio-net-pci",
>> "sungem",
>
> I think it would be better and more consisten to finally fix this mess
> and automatically allow all devices in the category
> DEVICE_CATEGORY_NETWORK that are derived from TYPE_PCI_DEVICE, instead
> of manually maintaining this list here...?
Yeah, that would make sense too (virtio would be special cased). Thanks!
Paolo