[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/4] rocker: drop local duplex definitions
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH 2/4] rocker: drop local duplex definitions |
Date: |
Fri, 2 Mar 2018 19:57:25 +0200 |
On Thu, Mar 01, 2018 at 10:46:34PM -0500, Jason Baron wrote:
> Make use of duplex definitions from net/eth.h.
>
> Signed-off-by: Jason Baron <address@hidden>
> Cc: "Michael S. Tsirkin" <address@hidden>
> Cc: Jason Wang <address@hidden>
> Cc: Jiri Pirko <address@hidden>
> Cc: address@hidden
> ---
> hw/net/rocker/rocker_fp.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/hw/net/rocker/rocker_fp.c b/hw/net/rocker/rocker_fp.c
> index 4b3c984..13a14a0 100644
> --- a/hw/net/rocker/rocker_fp.c
> +++ b/hw/net/rocker/rocker_fp.c
> @@ -16,17 +16,13 @@
>
> #include "qemu/osdep.h"
> #include "net/clients.h"
> +#include "net/eth.h"
>
> #include "rocker.h"
> #include "rocker_hw.h"
> #include "rocker_fp.h"
> #include "rocker_world.h"
>
> -enum duplex {
> - DUPLEX_HALF = 0,
> - DUPLEX_FULL
> -};
> -
This is hardware emulation, so I actually suspect it
should be renamed ROCKER_FP_HALF/ROCKER_FP_FULL.
> struct fp_port {
> Rocker *r;
> World *world;
> --
> 2.7.4
[Qemu-devel] [PATCH 2/4] rocker: drop local duplex definitions, Jason Baron, 2018/03/01
- Re: [Qemu-devel] [PATCH 2/4] rocker: drop local duplex definitions,
Michael S. Tsirkin <=
[Qemu-devel] [PATCH 3/4] virtio-net: use 64-bit values for feature flags, Jason Baron, 2018/03/01
[Qemu-devel] [PATCH 4/4] virtio-net: add linkspeed and duplex settings to virtio-net, Jason Baron, 2018/03/01
Re: [Qemu-devel] [PATCH 4/4] virtio-net: add linkspeed and duplex settings to virtio-net, Michael S. Tsirkin, 2018/03/02
Re: [Qemu-devel] [virtio-dev] [PATCH 4/4] virtio-net: add linkspeed and duplex settings to virtio-net, Yan Vugenfirer, 2018/03/04
Re: [Qemu-devel] [virtio-dev] [PATCH 4/4] virtio-net: add linkspeed and duplex settings to virtio-net, Jason Baron, 2018/03/06
Re: [Qemu-devel] [virtio-dev] [PATCH 4/4] virtio-net: add linkspeed and duplex settings to virtio-net, Michael S. Tsirkin, 2018/03/06