Re: [Qemu-devel] [PATCH v10 26/28] qmp: add query-sev-capabilities command

[Brijesh Singh]

On 03/01/2018 02:13 PM, Eric Blake wrote:
> On 02/28/2018 03:10 PM, Brijesh Singh wrote:
> > The command can be used by libvirt to query the SEV capabilities.
> >
> > Cc: "Daniel P. Berrangé" <address@hidden>
> > Cc: "Dr. David Alan Gilbert" <address@hidden>
> > Cc: Markus Armbruster <address@hidden>
> > Signed-off-by: Brijesh Singh <address@hidden>
> > ---
> >   monitor.c             |  7 +++++++
> >   qapi-schema.json      | 42 ++++++++++++++++++++++++++++++++++++++++++
> >   target/i386/monitor.c |  5 +++++
> >   3 files changed, 54 insertions(+)
>
> And another rebase victim.

I will wait for couple of days for more feedback then rebase the series.


> > +##
> > +# @query-sev-capabilities:
> > +#
> > +# This command is used to get the SEV capabilities and supported on AMD
>
> grammar suggestion: s/capabilities and/capabilities, and is/
>
> > +# X86 platform only.
>
> s/platform/platforms/

Will fix it.

> > +#
> > +# Returns: a list of SevCapability objects.
>
> This says it returns a list of objects...

Earlier I thought we may need list but we really need one element. I 
will fix it.


> > +#
> > +# Since: 2.12
> > +#
> > +# Example:
> > +#
> > +# -> { "execute": "query-sev-capabilities" }
>
> ...but this says it returns a single object.
>
> > +# <- { "return": { "pdh": "8CCDD8DDD", "cert-chain": "888CCCDDDEE",
> > +#                  "cbitpos": 47, "reduced-phys-bits": 5}}
> > +#
> > +##
> > +{ 'command': 'query-sev-capabilities', 'returns': 'SevCapability' }
> > diff --git a/target/i386/monitor.c b/target/i386/monitor.c
> > index 577d50eebaaa..1b55dd0fff88 100644
> > --- a/target/i386/monitor.c
> > +++ b/target/i386/monitor.c
> > @@ -737,3 +737,8 @@ SevLaunchMeasureInfo 
> > *qmp_query_sev_launch_measure(Error **errp)
> >       return info;
> >   }
> > +
> > +SevCapability *qmp_query_sev_capabilities(Error **errp)
> > +{
> > +    return NULL;
>
> Should call error_setg() before returning NULL.

Later in the patches this function gets filled with capability call and 
we set the error before returning NULL.