[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/9] chardev: introduce chr_machine_done hook
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH 5/9] chardev: introduce chr_machine_done hook |
Date: |
Tue, 6 Mar 2018 13:27:06 +0800 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Mon, Mar 05, 2018 at 11:54:22AM +0100, Marc-André Lureau wrote:
> Hi
>
> On Mon, Mar 5, 2018 at 7:50 AM, Peter Xu <address@hidden> wrote:
> > Introduce ChardevClass.chr_machine_done() hook so that chardevs can run
> > customized procedures after machine init.
> >
> > There was an existing mux user already that did similar thing but used a
> > raw machine done notifier. Generalize it into a framework, and let the
> > mux chardevs provide such a class-specific hook to achieve the same
> > thing. Then we can move the mux related code to the char-mux.c file.
> >
> > Since at it, replace the mux_realized variable with the global
> > machine_init_done varible.
> >
> > This notifier framework will be further leverged by other type of
> > chardevs soon.
> >
> > Reviewed-by: Paolo Bonzini <address@hidden>
> > Signed-off-by: Peter Xu <address@hidden>
>
> patchew caught that:
> tests/test-char.o: In function `char_mux_test':
> /tmp/qemu-test/src/tests/test-char.c:169: undefined reference to
> `muxes_realized'
Yeh, I replied to patchew mail with a fix to be squashed.
I was planning to repost some days later, but let me repost now in
case that it may ease the reviewers a bit. Thanks,
--
Peter Xu
- Re: [Qemu-devel] [PATCH 1/9] vl: export machine_init_done, (continued)
- [Qemu-devel] [PATCH 2/9] chardev: fix leak in tcp_chr_telnet_init_io(), Peter Xu, 2018/03/05
- [Qemu-devel] [PATCH 3/9] chardev: update net listener gcontext, Peter Xu, 2018/03/05
- [Qemu-devel] [PATCH 4/9] chardev: allow telnet gsource to switch gcontext, Peter Xu, 2018/03/05
- [Qemu-devel] [PATCH 6/9] chardev: use chardev's gcontext for async connect, Peter Xu, 2018/03/05
- [Qemu-devel] [PATCH 5/9] chardev: introduce chr_machine_done hook, Peter Xu, 2018/03/05
- [Qemu-devel] [PATCH 7/9] chardev: tcp: postpone async connection setup, Peter Xu, 2018/03/05
- [Qemu-devel] [PATCH 8/9] chardev: tcp: let TLS run on chardev context, Peter Xu, 2018/03/05
- [Qemu-devel] [PATCH 9/9] chardev: tcp: postpone TLS work until machine done, Peter Xu, 2018/03/05
- Re: [Qemu-devel] [PATCH 0/9] chardev: qio related non-default context support, no-reply, 2018/03/05