[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4] qapi: Add device ID and head parameters to s
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH v4] qapi: Add device ID and head parameters to screendump |
Date: |
Tue, 6 Mar 2018 10:01:11 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 05.03.2018 17:50, Eric Blake wrote:
> On 03/05/2018 10:37 AM, Thomas Huth wrote:
>> QEMU's screendump command can only take dumps from the primary display.
>> When using multiple VGA cards, there is no way to get a dump from a
>> secondary card or other display heads yet. So let's add an 'device' and
>
> s/an/a/
Gerd, could you please fix that up when picking up the patch? Thanks!
>> a 'head' parameter to the HMP and QMP commands to be able to specify
>> alternative devices and heads with the screendump command, too.
>>
>> Reviewed-by: Daniel P. Berrangé <address@hidden>
>> Acked-by: Dr. David Alan Gilbert <address@hidden>
>> Reviewed-by: Gerd Hoffmann <address@hidden>
>> Signed-off-by: Thomas Huth <address@hidden>
>> ---
>
> Reviewed-by: Eric Blake <address@hidden>
Thanks for the reviews!
Thomas