[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/2] s390x: Change return type of virtio_ccw_
|
From: |
Cornelia Huck |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 2/2] s390x: Change return type of virtio_ccw_exit to void. |
|
Date: |
Tue, 6 Mar 2018 15:40:13 +0100 |
On Tue, 6 Mar 2018 10:07:21 +0000
Nia Alarie <address@hidden> wrote:
> Allows a branch to be removed - this function always returns 0.
>
> Signed-off-by: Nia Alarie <address@hidden>
> Reviewed-by: Christian Borntraeger <address@hidden>
> ---
> hw/s390x/virtio-ccw.c | 6 +++---
> hw/s390x/virtio-ccw.h | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
While your patch is not wrong, I'd prefer to skip changing the exit
functions and convert virtio-ccw to unrealize instead.
Should not be too hard; do you want to take a stab at it?