Re: [Qemu-devel] [PATCH V4 4/7] CAN bus Kvaser PCI CAN-S (single SJA1000 channel) emulation added.

[Thomas Huth]

On 14.01.2018 21:14, address@hidden wrote:
> From: Pavel Pisa <address@hidden>
> 
> Signed-off-by: Pavel Pisa <address@hidden>
> ---
>  default-configs/pci.mak |   1 +
>  hw/can/Makefile.objs    |   1 +
>  hw/can/can_kvaser_pci.c | 375 
> ++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 377 insertions(+)
>  create mode 100644 hw/can/can_kvaser_pci.c

 Hi,

the kvaser_pci device introduced a new way to crash QEMU, e.g.:

mips64el-softmmu/qemu-system-mips64el -M malta,accel=qtest \
                                      -device kvaser_pci

Program received signal SIGSEGV, Segmentation fault.
0x0000555555a6e2ec in can_bus_insert_client (bus=0x0, address@hidden)
    at /home/thuth/devel/qemu/net/can/can_core.c:50
50          QTAILQ_INSERT_TAIL(&bus->clients, client, next);
(gdb) bt
#0  0x0000555555a6e2ec in can_bus_insert_client (bus=0x0, address@hidden)
    at /home/thuth/devel/qemu/net/can/can_core.c:50
#1  0x00005555559d7364 in can_sja_connect_to_bus (address@hidden, 
bus=<optimized out>)
    at /home/thuth/devel/qemu/hw/net/can/can_sja1000.c:869
#2  0x00005555559d75a4 in kvaser_pci_realize (pci_dev=0x5555570c33d0, 
errp=0x7fffffffd8e0)
    at /home/thuth/devel/qemu/hw/net/can/can_kvaser_pci.c:230
#3  0x00005555559e12f1 in pci_qdev_realize (qdev=0x5555570c33d0, 
errp=0x7fffffffd980)
    at /home/thuth/devel/qemu/hw/pci/pci.c:2029
#4  0x0000555555963c3a in device_set_realized (obj=<optimized out>, 
value=<optimized out>, errp=0x7fffffffdab8)
    at /home/thuth/devel/qemu/hw/core/qdev.c:852
#5  0x0000555555aa7a7e in property_set_bool (obj=0x5555570c33d0, v=<optimized 
out>, name=<optimized out>, opaque=0x555556f6d220, errp=0x7fffffffdab8) at 
/home/thuth/devel/qemu/qom/object.c:1906
#6  0x0000555555aabbef in object_property_set_qobject (address@hidden, 
address@hidden, address@hidden "realized", address@hidden)
    at /home/thuth/devel/qemu/qom/qom-qobject.c:27
#7  0x0000555555aa9860 in object_property_set_bool (obj=0x5555570c33d0, 
value=<optimized out>, name=0x555555c7079f "realized", errp=0x7fffffffdab8) at 
/home/thuth/devel/qemu/qom/object.c:1171
#8  0x00005555558eb1d9 in qdev_device_add (opts=0x55555689ff40, address@hidden)
    at /home/thuth/devel/qemu/qdev-monitor.c:634
#9  0x00005555558ed547 in device_init_func (opaque=<optimized out>, 
opts=<optimized out>, errp=<optimized out>)
    at /home/thuth/devel/qemu/vl.c:2350
#10 0x0000555555b8d75a in qemu_opts_foreach (list=<optimized out>, 
address@hidden
    0x5555558ed520 <device_init_func>, address@hidden, address@hidden)
    at /home/thuth/devel/qemu/util/qemu-option.c:1073
#11 0x00005555557b8f64 in main (argc=<optimized out>, argv=<optimized out>, 
envp=<optimized out>)
    at /home/thuth/devel/qemu/vl.c:4618

Could you please fix this?

 Thanks,
  Thomas