[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v10 18/24] migration: Add multifd traces for sta
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-devel] [PATCH v10 18/24] migration: Add multifd traces for start/end thread |
Date: |
Wed, 7 Mar 2018 12:11:26 +0000 |
User-agent: |
Mutt/1.9.2 (2017-12-15) |
On Wed, Mar 07, 2018 at 12:00:04PM +0100, Juan Quintela wrote:
> Signed-off-by: Juan Quintela <address@hidden>
> ---
> migration/ram.c | 6 ++++++
> migration/trace-events | 4 ++++
> 2 files changed, 10 insertions(+)
>
> diff --git a/migration/trace-events b/migration/trace-events
> index 76075c26bc..db88fa699f 100644
> --- a/migration/trace-events
> +++ b/migration/trace-events
> @@ -79,6 +79,10 @@ ram_save_page(const char *rbname, uint64_t offset, void
> *host) "%s: offset: 0x%"
> ram_save_queue_pages(const char *rbname, size_t start, size_t len) "%s:
> start: 0x%zx len: 0x%zx"
> multifd_send_sync_main(void) ""
> multifd_recv_sync_main(void) ""
> +multifd_send_thread_start(int id) "%d"
> +multifd_send_thread_end(int id) "%d"
> +multifd_recv_thread_start(int id) "%d"
> +multifd_recv_thread_end(int id) "%d"
Seems these should have been 'uint8_t' rather than 'int', avoiding the
change of type in later patches
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [Qemu-devel] [PATCH v10 14/24] migration: Be sure all recv channels are created, (continued)
- [Qemu-devel] [PATCH v10 14/24] migration: Be sure all recv channels are created, Juan Quintela, 2018/03/07
- [Qemu-devel] [PATCH v10 01/24] tests: Add migration precopy test, Juan Quintela, 2018/03/07
- [Qemu-devel] [PATCH v10 10/24] migration: In case of error just end the migration, Juan Quintela, 2018/03/07
- [Qemu-devel] [PATCH v10 02/24] tests: Add migration xbzrle test, Juan Quintela, 2018/03/07
- [Qemu-devel] [PATCH v10 13/24] migration: Introduce multifd_recv_new_channel(), Juan Quintela, 2018/03/07
- [Qemu-devel] [PATCH v10 18/24] migration: Add multifd traces for start/end thread, Juan Quintela, 2018/03/07
- [Qemu-devel] [PATCH v10 16/24] migration: Synchronize recv threads, Juan Quintela, 2018/03/07
- [Qemu-devel] [PATCH v10 15/24] migration: Synchronize send threads, Juan Quintela, 2018/03/07
- [Qemu-devel] [PATCH v10 19/24] migration: Create multifd channels, Juan Quintela, 2018/03/07
[Qemu-devel] [PATCH v10 23/24] migration: Create pages structure for reception, Juan Quintela, 2018/03/07
[Qemu-devel] [PATCH v10 21/24] migration: Transmit initial package through the multifd channels, Juan Quintela, 2018/03/07