Re: [Qemu-devel] [PATCH] trace: fix ARM TrustZone PPC hwaddr type

[Stefan Hajnoczi]

On Tue, Mar 06, 2018 at 03:40:23PM -0300, Philippe Mathieu-Daudé wrote:
> On 03/06/2018 02:22 PM, Stefan Hajnoczi wrote:
> > Commit 9eb8040c2d2b ("hw/misc/tz-ppc: Model TrustZone peripheral
> > protection controller") added trace events with hwaddr type arguments.
> > 
> > This is not allowed and leads to the following compiler errors when
> > building with ./configure --enable-trace-backends=ust:
> > 
> >   trace-ust-all.h:11847:20: error: unknown type name ‘hwaddr’; did you mean 
> > ‘h_addr’?
> >     TP_ARGS(int, n, hwaddr, offset, bool, secure, bool, user),
> > 
> > Generated LTTng UST tracepoint definitions cannot include declarations
> > for all QEMU types and therefore docs/devel/tracing.txt requires using
> > only primitive or stdint.h types.
> 
> Maybe the trace generator script can check for legal/forbidden types?

Yes, good idea.  I'll add it to my todo list.

Stefan

signature.asc
Description: PGP signature