Re: [Qemu-devel] [PATCH] trace: only permit standard C types and fixed size integer types

[Stefan Hajnoczi]

On Tue, Mar 06, 2018 at 03:46:25PM +0000, Daniel P. Berrangé wrote:
> Some trace backends will compile code based on the declared trace
> events. It should not be assumed that the backends can resolve any QEMU
> specific typedefs. So trace events should restrict their argument
> types to the standard C types and fixed size integer types. Any complex
> pointer types can be declared as "void *" for purposes of trace events,
> since nothing will be dereferencing these pointer arguments.
> 
> Signed-off-by: Daniel P. Berrangé <address@hidden>
> ---
>  scripts/tracetool/__init__.py | 45 
> +++++++++++++++++++++++++++++++++++++++++++
>  trace-events                  |  6 +++---
>  2 files changed, 48 insertions(+), 3 deletions(-)

Looks good, thanks!  I'll merge the next revision.

Stefan

signature.asc
Description: PGP signature