Re: [Qemu-devel] [PULL] RISC-V QEMU Port Submission v8.2

[Peter Maydell]

On 6 March 2018 at 19:46, Michael Clark <address@hidden> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> The following changes since commit f32408f3b472a088467474ab152be3b6285b2d7b:
>
>   misc: don't use hwaddr as a type in trace events (2018-03-06 14:24:30 +0000)
>
> are available in the git repository at:
>
>   https://github.com/riscv/riscv-qemu.git tags/riscv-qemu-upstream-v8.2
>
> for you to fetch changes up to 7051b081bf6796e5e84406f6223a7c4900bf7298:
>
>   RISC-V - Remove support for adhoc non-standard X_COP local-interrupt 
> (2018-03-07 08:36:03 +1300)


Hi -- I would have applied this, but some of the commits
have no signed-off-by lines.

This is important, and I've already asked for it once. We cannot
accept anything that doesn't have a clear record in the commit
message of everybody (person or company) who's contributed code
to it, indicating that they're happy for their copyrighted
contributions to be taken into QEMU under our license. Lists
of names without emails in the cover letter are not sufficient.

In fact a lot of the last part of this patchset looks like
unreviewed changes/fixes that if we were going to have them we
should have squashed into the correct patches and resent the
series for review. Please don't do this. Code review is an
important part of how the QEMU project works.

thanks
-- PMM