Re: [Qemu-devel] [PATCH] ppc440_pcix: Add dummy implementation of BRDGOPT registers

[BALATON Zoltan]

On Thu, 8 Mar 2018, David Gibson wrote:
> On Wed, Mar 07, 2018 at 09:43:59PM +0100, BALATON Zoltan wrote:
> > I don't know what should be the correct implementation for these so
> > these are just stored and returned as is without doing anything for
> > now only to silence warnings when u-boot accesses these registers.
> >
> > Signed-off-by: BALATON Zoltan <address@hidden>
>
> I'm a bit dubious about putting in a dummy register implementation.
> Specifically, I think the case needs to be made that the dummy
> implementation is preferable to just putting up with the test errors.
>
> At the very least there should be a comment in the code indicating
> that it's just a dummy stub implementation.

Let's go with changing the error_report to qemu_log_mask(LOG_UNIMP, ...) 
as suggested by Thomas instead. I'll send another patch.

Regards,
BALATON Zoltan