[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/11] xen: defer call to xen_restrict until jus
From: |
Ian Jackson |
Subject: |
Re: [Qemu-devel] [PATCH 03/11] xen: defer call to xen_restrict until just before os_setup_post |
Date: |
Fri, 9 Mar 2018 11:33:35 +0000 |
Eduardo Habkost writes ("Re: [PATCH 03/11] xen: defer call to xen_restrict
until just before os_setup_post"):
> On Thu, Mar 08, 2018 at 05:39:09PM +0000, Ian Jackson wrote:
> [...]
> > diff --git a/vl.c b/vl.c
> > + xen_setup_post();
>
> I don't think we should have accelerator-specific code in main(),
> if we already have accelerator classes that can abstract that
> out. I suggest adding a AccelClass;:setup_post() method that can
> be called here.
I think I can do that.
Although, it is a bit disappointing to be given this feedback in v6 of
this series. Did the right people not get CC'd on v5 in October ?
Ian.
- [Qemu-devel] [PATCH 01/11] xen: link against xentoolcore, (continued)
- [Qemu-devel] [PATCH 01/11] xen: link against xentoolcore, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 10/11] xen: Expect xenstore write to fail when restricted, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 04/11] xen: destroy_hvm_domain: Move reason into a variable, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 08/11] configure: do_compiler: Dump some extra info under bash, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 07/11] os-posix: Provide new -runas <uid>:<gid> facility, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 06/11] xen: destroy_hvm_domain: Try xendevicemodel_shutdown, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 11/11] scripts/get_maintainer.pl: Print proper error message for missing $file, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 02/11] xen: restrict: use xentoolcore_restrict_all, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 03/11] xen: defer call to xen_restrict until just before os_setup_post, Ian Jackson, 2018/03/08
- Re: [Qemu-devel] [PATCH 03/11] xen: defer call to xen_restrict until just before os_setup_post, Eduardo Habkost, 2018/03/09
Re: [Qemu-devel] [PATCH v6 00/11] xen: xen-domid-restrict improvements, no-reply, 2018/03/08
Re: [Qemu-devel] [PATCH v6 00/11] xen: xen-domid-restrict improvements, no-reply, 2018/03/08
Re: [Qemu-devel] [PATCH v6 00/11] xen: xen-domid-restrict improvements, no-reply, 2018/03/08